Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to configure admin access to script configuration changes #359

Closed
bugy opened this issue Nov 1, 2020 · 1 comment
Closed

Comments

@bugy
Copy link
Owner

bugy commented Nov 1, 2020

Based on the following comment:

@bugy this "bug" is actually a feature, I'm leveraging it to separate the admin permissions of admins from different teams which shouldn't manage and access each other scripts. it was completely awesome if this feature was effecting also the script audit screen, which will allow admins to see audits items only of Scripts they are in the "allowed users".
Anyway please don't fix this bug which will actually kill a great feature

Originally posted by @Alonel in #342 (comment)

@bugy bugy added this to the 1.16.0 milestone Nov 1, 2020
@bugy
Copy link
Owner Author

bugy commented Nov 1, 2020

Now there is "admin_users" setting for a script configuration (also configurable in UI). Only admins, which are listed in "admin_users" would be able to modify a script (and see it on the admin page)

@bugy bugy closed this as completed Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant