Option for put no space between parameter and value

[IncredibleRichie]

To execute packer with the parameter
-var-file=

you need to put the path directly behind
'='
with no space.

When i select a server-file it puts a whithespace between the parameter and the path.

At the moment i think this is not posible to change the behavior.
If it is can u tell me how?

btw. Thanks for your great work.

[bugy]

Hey, unfortunately, it's not supported :(
For some reason, nobody ever asked about it (at least I couldn't find a ticket)

[IncredibleRichie]

I looked for it too becauce i could not belive it. ^^

[bugy]

From #308
@miksir wrote:

Hi! I got a request for support --arg=value. Currently there is no options to do it because space added between argument name and value. I can see two ways - separate options for it (do_not_add_space \o/) or transparent behaviour - if arg name ended with = - do not include space. What you think about second way?

Hi @miksir I think the second one is cooler, though a bit dangerous. I think we can try it and see if there are any complaints :)

[miksir]

ok, will make PR today

[yosefy]

example: terraform apply -var="image_id=ami-abc123"

…

On Wed, Jun 10, 2020 at 1:52 PM miksir ***@***.***> wrote: ok, will make PR today — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#288 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADCXF3KLGYXO7QFH7C5A7MTRV5QWLANCNFSM4L4JTVSA> .

[bugy]

Hi @yosefy, how do you do it now? With a wrapping script?

[miksir]

Is quotes required here? Usually quotes used only if value with spaces and only because shell use space as arg delimiter. But in case of popen args passed to system as separate items and quotes not required. Am I right?

[miksir]

How mutiple arguments list shoud work?
--arg=a b c
--arg=a,b,c
--arg=a --arg=b --arg=c

[bugy]

@miksir I think in the same way as normal behavior. By using separator and multiple_arguments configs, you can achieve the last 2 results.
The first one doesn't make much sense to me (to have the last 2 arguments as separate arguments). I've never seen such behaviour before

[miksir]

Last one you can't achieve. multiple_arguments with separator= --arg= will give you --arg=a --arg=b --arg=c - one argument (it's like --arg="a --arg=b --arg=c" in command line).

Same trouble with current behavior.

    {
      "name": "Name",
      "param": "-d",
      "type": "multiselect",
      "values": [
        "a",
        "b",
        "c"
      ],
      "multiple_arguments": true
    }

Gives

0=temp/test.sh
1=-d
2=a
3=b
4=c

but

    {
      "name": "Name",
      "param": "-d",
      "type": "multiselect",
      "values": [
        "a",
        "b",
        "c"
      ],
      "multiple_arguments": false,
      "separator": " -d "
    }

gives

0=temp/test.sh
1=-d
2=a -d b -d c
3=
4=

so there is no way to make 1=-d 2=a 3=-d 4=b as if we called it from command line

[miksir]

My suggestion is to change current behaviour too, but its breaks BC :(
Or add option "add Arg to each value".
Or leave current behaviour untouched but for -arg= change this behaviour and implement --arg=a --arg=b --arg=c

[yosefy]

yep

…

On Wed, Jun 10, 2020 at 2:04 PM Iaroslav Shepilov ***@***.***> wrote: Hi @yosefy <https://github.com/yosefy>, how do you do it now? With a wrapping script? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#288 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADCXF3NB2F42MOAFF4UGL73RV5SDXANCNFSM4L4JTVSA> .

[bugy]

Ah, true, that case is missing.
But I wouldn't change current behaviour, as it makes sense, to be honest. Some scripts could expect -b 1 2 3 and other would expect -b 1 -b 2 -b 3

I think both of your 2nd and 3rd proposals make sense. There can be such option (may be, I would call it repeat_param), which would be enabled by default for the -arg= parameters.

[miksir]

Never saw -b 1 2 3 variants... -b "1 2 3" - yes, but separate args? Usually it's -b <b arg> <new arg> <new arg> - so just additional args.

[bugy]

https://stackoverflow.com/questions/15753701/how-can-i-pass-a-list-as-a-command-line-argument-with-argparse here different answers suggest different syntax styles, with all 3 variants here.
(It was the first SO result for google request: "python argparse list")

So I would assume all 3 variants exist in a wild

[miksir]

PR #310