Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breadcrumbs not included in uncaught exceptions #93

Closed
anderscarling opened this issue Feb 9, 2016 · 3 comments
Closed

Breadcrumbs not included in uncaught exceptions #93

anderscarling opened this issue Feb 9, 2016 · 3 comments

Comments

@anderscarling
Copy link

It seems like breadcrumbs logged with Bugsnag+leaveBreadcrumbWithMessage: is not included when logging uncaught nsexceptions.

Root cause seems to be that the breadcrumbs are only added to configuration.metaData in notify:withData:atSeverity:atDepth: which only seems to be used for manually reported exceptions.
When KSCrash calls serialize_bugsnag_data (as it's onCrash callback) for other exception types breadcrumbs will not be in the meta data struct.

Manually hacking the situation by calling [[Bugsnag performSelector:@selector(notifier)] performSelector:@selector(serializeBreadcrumbs)]; after each call to leaveBreadcrumbWithMessage seems to work around the issue.

@kattrali
Copy link
Contributor

kattrali commented Feb 9, 2016

Thank you for the report, @anderscarling. You are correct that the latest release does not include breadcrumbs with uncaught exceptions. However this issue has been resolved per #86, which should be released later this week.

@kattrali kattrali closed this as completed Feb 9, 2016
@anderscarling
Copy link
Author

Cool, thanks! Sorry that I didn't check recent changes before writing up an issue.

@kattrali
Copy link
Contributor

kattrali commented Feb 9, 2016

No problem, glad to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants