Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot build with frameworks: KSCrash/KSCrashAdvanced.h file not found #101

Closed
SSheldon opened this issue Feb 27, 2016 · 4 comments
Closed

Comments

@SSheldon
Copy link

I'm integrating Bugsnag 5.0.2 via CocoaPods with a Podfile set to use_frameworks! and get a compiler error when compiling Bugsnag:

Pods/Bugsnag/Source/Bugsnag.m:32:9: 'KSCrash/KSCrashAdvanced.h' file not found

The issue does not occur when building static libraries, i.e. with use_frameworks! removed from the Podfile.

It appears that KSCrashAdvanced.h is a private header in KSCrash 1.0.1. Starting with kstenerud/KSCrash@0114ae0, only certain headers are public in KSCrash. This was noticed and fixed in kstenerud/KSCrash#124 by adding a KSCrash/Reporting/Advanced subspec. However, a new version of KSCrash has not yet been published.

I believe to fix this:

  1. A new 1.0.2 version of KSCrash will need to be published
  2. Bugsnag will need to be updated to include a KSCrash/Reporting/Advanced dependency at version 1.0.2
@SSheldon
Copy link
Author

Alternatively, since KSCrashAdvanced.h wasn't private in version 1.0.0 of KSCrash, this could potentially be resolved by downgrading the dependency to allow that version, but I'm not sure if anything was changed in 1.0.1 of KSCrash that Bugsnag depends on.

@SSheldon
Copy link
Author

Okay, version 1.0.2 of KSCrash was tagged, but the changes to its spec in 1.0.2 now have caused it to not build with use_frameworks!. I'll look into that some more.

@SSheldon
Copy link
Author

🎉 wooh with the kstenerud/KSCrash#127 PR I opened I'm finally able to build with frameworks!

Working podfile looks like:

platform :ios, '8.0'
use_frameworks!

target 'PodsTest' do
  pod 'Bugsnag', '5.0.2'
  pod 'KSCrash/RecordingAdvanced', :git => '[email protected]:SSheldon/KSCrash.git', :branch => 'frameworks_advanced'
end

@kattrali
Copy link
Contributor

Awesome work, @SSheldon. Thanks for looking into this. I'm taking a look at fixing #100 and shipping a patch release for this along with it. Hopefully now the subspecs are divided as needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants