Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enum validation fails when enum defined in different package #321

Closed
snowp opened this issue Mar 6, 2020 · 8 comments
Closed

enum validation fails when enum defined in different package #321

snowp opened this issue Mar 6, 2020 · 8 comments
Labels
Stale Activity has stalled on this issue/pull-request

Comments

@snowp
Copy link
Contributor

snowp commented Mar 6, 2020

Using the following validation

  envoy.common.ipc_metrics.kind.TrafficType traffic_type = 1 [(validate.rules).enum = {not_in: [0]}];

fails with

::TrafficType'?
        const std::set<TrafficType> _AtlasAccessLog_TrafficType_NotInLookup = {
                       ^~~~~~~~~~~
                       common::ipc_metrics::kind::TrafficType

Seems like the generated code is not including the fully qualified name of the enum type

@stale
Copy link

stale bot commented Apr 5, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Activity has stalled on this issue/pull-request label Apr 5, 2020
@stale stale bot closed this as completed Apr 12, 2020
@akonradi
Copy link
Contributor

@snowp is this still an issue? Is this for C++ only or other languages as well? Would you be able to work on a PR?

@akonradi akonradi reopened this Jul 20, 2020
@stale stale bot removed the Stale Activity has stalled on this issue/pull-request label Jul 20, 2020
@snowp
Copy link
Contributor Author

snowp commented Jul 31, 2020

I haven't run into this issue recently so it might have gotten fixed for all I know. I only saw this in C++.

If I find the time I can try to reproduce this and work on a fix, but it's not high on my priorities.

@stale
Copy link

stale bot commented Aug 30, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added Stale Activity has stalled on this issue/pull-request and removed Stale Activity has stalled on this issue/pull-request labels Aug 30, 2020
@manuelnp
Copy link

manuelnp commented Sep 23, 2020

I just suffered this issue, only in C++.

@anopheles
Copy link

The issue is also available within go, using following go release [email protected]

@stale
Copy link

stale bot commented Nov 16, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Activity has stalled on this issue/pull-request label Nov 16, 2020
@stale stale bot closed this as completed Dec 12, 2020
@hurrycane
Copy link

I can confirm this is an issue -- no imports for enums defined in a different package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale Activity has stalled on this issue/pull-request
Projects
None yet
Development

No branches or pull requests

5 participants