Add logs to debug NoSuchFileException during segments upload (opensea…

…rch-project#8475) Signed-off-by: Ashish Singh <[email protected]> Signed-off-by: sahil buddharaju <[email protected]>
buddharajusahil · Jul 18, 2023 · 0c55963 · 0c55963
1 parent a5907aa
commit 0c55963
Showing 1 changed file with 11 additions and 1 deletion.
diff --git a/server/src/main/java/org/opensearch/index/shard/RemoteStoreRefreshListener.java b/server/src/main/java/org/opensearch/index/shard/RemoteStoreRefreshListener.java
@@ -224,7 +224,17 @@ private synchronized void syncSegments(boolean isRetry) {
                         // Each metadata file in the remote segment store represents a commit and the following
                         // statement keeps sure that each metadata will always contain all the segments from last commit + refreshed
                         // segments.
-                        localSegmentsPostRefresh.addAll(SegmentInfos.readCommit(storeDirectory, latestSegmentInfos.get()).files(true));
+                        SegmentInfos segmentCommitInfos;
+                        try {
+                            segmentCommitInfos = SegmentInfos.readCommit(storeDirectory, latestSegmentInfos.get());
+                        } catch (Exception e) {
+                            // Seeing discrepancy in segment infos and files on disk. SegmentInfosSnapshot is returning
+                            // a segment_N file which does not exist on local disk.
+                            logger.error("Exception occurred while SegmentInfos.readCommit(..)", e);
+                            logger.error("segmentInfosFiles={} diskFiles={}", localSegmentsPostRefresh, storeDirectory.listAll());
+                            throw e;
+                        }
+                        localSegmentsPostRefresh.addAll(segmentCommitInfos.files(true));
                         segmentInfosFiles.stream()
                             .filter(file -> !file.equals(latestSegmentInfos.get()))
                             .forEach(localSegmentsPostRefresh::remove);