Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to go forward one month #40

Closed
iffy opened this issue Jan 15, 2018 · 7 comments
Closed

Unable to go forward one month #40

iffy opened this issue Jan 15, 2018 · 7 comments
Labels
bug Things that prevent or seriously impede people from doing their budget. included in next release The work is done, it's just waiting to be released.
Milestone
Buckets v1.0

Comments

@iffy
Copy link
Contributor

iffy commented Jan 15, 2018

One user isn't able to go to the next month (by pressing the right arrow at the top next to the date). Also, the "Target date" dropdown defaults to the month before the current month.

Both of these make me suspect it's a timezone issue.
@iffy iffy added bug Things that prevent or seriously impede people from doing their budget. included in next release The work is done, it's just waiting to be released. labels Jan 15, 2018
@iffy
Copy link
Contributor Author

iffy commented Jan 15, 2018

Included in v0.25.1 release

@iffy iffy closed this as completed Jan 15, 2018
@iffy iffy reopened this Jan 17, 2018
@iffy
Copy link
Contributor Author

iffy commented Jan 17, 2018

This is still an issue.

OS: Ubuntu 17.10 (installed the .deb Package)
Timezone: CET (Vienna/Austria)

  • Clicking left arrow moves back 2 months (instead of 1).
  • Clicking right arrow does nothing.
  • Clicking the month dropdown and choosing a value, it will actually choose one month prior.
  • Changing the year back one also moves the month back one.
  • If it's on JAN 1999 and I change to 1998, the final state is DEC 1997

@iffy iffy removed the included in next release The work is done, it's just waiting to be released. label Jan 17, 2018
@iffy
Copy link
Contributor Author

iffy commented Jan 17, 2018

I installed v0.25.0 in an Ubuntu 17.10 VM set to the CET timezone and I didn't see the bug. I'll have to debug some other way.

@iffy iffy added this to the v1.0.0 milestone Jan 20, 2018
@iffy
Copy link
Contributor Author

iffy commented Jan 24, 2018 •
edited
Loading

A snippet of logs which shows that something timezone-related is happening. See how it goes from +01:00 to +02:00?

[2018-01-24 20:48:15.786] [silly] (budget.r) RENDERING
[2018-01-24 20:48:15.793] [silly] (budget.r) rendering monthselector with date 2018-01-01T00:00:00+01:00
[2018-01-24 20:48:22.364] [silly] (input) setDate 2018-07-01T00:00:00+02:00
[2018-01-24 20:48:22.431] [silly] (budget.r) RENDERING
[2018-01-24 20:48:22.449] [silly] (budget.r) rendering monthselector with date 2018-01-01T00:00:00+01:00

@iffy
Copy link
Contributor Author

iffy commented Jan 24, 2018

Also, the monthselector is started with a certain date (2018-01-01) but has a current date of something different later (2018-02-01):

[2018-01-24 20:46:48.036] [silly] (budget.r) RENDERING
[2018-01-24 20:46:48.042] [silly] (budget.r) rendering monthselector with date 2018-01-01T00:00:00+01:00
[2018-01-24 20:46:55.063] [silly] (input) click increment -1
[2018-01-24 20:46:55.065] [silly] (input) current date 2018-02-01T00:00:00+01:00
[2018-01-24 20:46:55.066] [silly] (input) new_date 2018-01-01T00:00:00+01:00
[2018-01-24 20:46:55.066] [silly] (input) setDate 2018-01-01T00:00:00+01:00

@iffy iffy added the included in next release The work is done, it's just waiting to be released. label Jan 24, 2018
@iffy
Copy link
Contributor Author

iffy commented Jan 25, 2018

Included in v0.30.0 release

@iffy iffy closed this as completed Jan 25, 2018
@iffy
Copy link
Contributor Author

iffy commented Jan 29, 2018

Included in v0.31.0 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Things that prevent or seriously impede people from doing their budget. included in next release The work is done, it's just waiting to be released.
Projects
None yet
Milestone
Buckets v1.0
Development

No branches or pull requests
1 participant
@iffy