Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When importing from CSV, dates order is wrong #329

Closed
AAverin opened this issue Dec 19, 2018 · 5 comments
Closed

When importing from CSV, dates order is wrong #329

AAverin opened this issue Dec 19, 2018 · 5 comments
Labels
bug Things that prevent or seriously impede people from doing their budget. included in next release The work is done, it's just waiting to be released.

Comments

@AAverin
Copy link

AAverin commented Dec 19, 2018

Because there is no "time" in CSV imports, only date, when importing, transactions end up in the wrong order.
When importing CSV, it should be possible to say in which order transactions should be put. At the moment, Buckets inverts transactions order and my latest transactions and up at the bottom.

For example, in the CSV transactions will be ordered with latest being on the top of the list
After the import, those transactions end up at the bottom of the list, sorted by date

@iffy
Copy link
Contributor

iffy commented Dec 19, 2018

@AAverin From your description, it would be sufficient to add an option to import in reverse order, right?

@iffy iffy added the bug Things that prevent or seriously impede people from doing their budget. label Dec 19, 2018
@AAverin
Copy link
Author

AAverin commented Dec 19, 2018

@iffy depends on how the import actually works.
I assume it's in reverse order, but if you order by date, and all date entires are equal – resulting order will depend on the sorting algorithm you use =) They can be just mixed

I would propose to add +1 second to every entry in CSV starting from the bottom, and then sort by date+time. Then you can apply the order and support reverse, if necessary, but all entries will have stable place in transactions

@iffy
Copy link
Contributor

iffy commented Dec 19, 2018

@AAverin I guess I'm asking if the CSV has them in the correct order (or the correct reverse order). If it does, then adding the sort option ought to work (using the incrementing internal transaction id as the tie-breaker for transactions on the same date).

@AAverin
Copy link
Author

AAverin commented Dec 20, 2018

CSVs that I used so far were in the correct order, but exposed only the date of the transaction and not the time.

@iffy iffy added the included in next release The work is done, it's just waiting to be released. label Jan 29, 2022
@iffy
Copy link
Contributor

iffy commented Feb 17, 2022

Included in v0.65.0 release (AUTOMATED COMMENT)

@iffy iffy closed this as completed Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Things that prevent or seriously impede people from doing their budget. included in next release The work is done, it's just waiting to be released.
Projects
None yet
Development

No branches or pull requests

2 participants