Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSV import error #190

Closed
iffy opened this issue Apr 30, 2018 · 5 comments
Closed

CSV import error #190

iffy opened this issue Apr 30, 2018 · 5 comments
Labels
bug Things that prevent or seriously impede people from doing their budget. included in next release The work is done, it's just waiting to be released.
Milestone
Buckets v1.0

Comments

@iffy
Copy link
Contributor

iffy commented Apr 30, 2018

From the logs, looks like this was part of a macro import

[2018-04-30 17:22:57.853] [error] (budget.r) Uncaught error: Uncaught TypeError: Cannot read property 'push' of undefined
[2018-04-30 17:22:57.854] [error] (budget.r) TypeError: Cannot read property 'push' of undefined
    at Object.keys.sort.forEach.header (/Applications/Buckets.app/Contents/Resources/app.asar/src/csvimport.js:91:34)
    at Array.forEach (native)
    at invertMapping (/Applications/Buckets.app/Contents/Resources/app.asar/src/csvimport.js:89:44)
    at CSVMapper.computeFormatOptionsAndBestGuess (/Applications/Buckets.app/Contents/Resources/app.asar/src/csvimport.js:207:36)
    at onChange (/Applications/Buckets.app/Contents/Resources/app.asar/src/csvimport.js:254:70)
    at HTMLUnknownElement.callCallback (/Applications/Buckets.app/Contents/Resources/app.asar/node_modules/react-dom/cjs/react-dom.development.js:104:14)
    at Object.invokeGuardedCallbackDev (/Applications/Buckets.app/Contents/Resources/app.asar/node_modules/react-dom/cjs/react-dom.development.js:142:16)
    at Object.invokeGuardedCallback (/Applications/Buckets.app/Contents/Resources/app.asar/node_modules/react-dom/cjs/react-dom.development.js:191:29)
    at Object.invokeGuardedCallbackAndCatchFirstError (/Applications/Buckets.app/Contents/Resources/app.asar/node_modules/react-dom/cjs/react-dom.development.js:205:43)
    at executeDispatch (/Applications/Buckets.app/Contents/Resources/app.asar/node_modules/react-dom/cjs/react-dom.development.js:470:19)
    at executeDispatchesInOrder (/Applications/Buckets.app/Contents/Resources/app.asar/node_modules/react-dom/cjs/react-dom.development.js:492:5)
    at executeDispatchesAndRelease (/Applications/Buckets.app/Contents/Resources/app.asar/node_modules/react-dom/cjs/react-dom.development.js:590:5)
    at executeDispatchesAndReleaseTopLevel (/Applications/Buckets.app/Contents/Resources/app.asar/node_modules/react-dom/cjs/react-dom.development.js:601:10)
    at forEachAccumulated (/Applications/Buckets.app/Contents/Resources/app.asar/node_modules/react-dom/cjs/react-dom.development.js:571:8)
    at runEventsInBatch (/Applications/Buckets.app/Contents/Resources/app.asar/node_modules/react-dom/cjs/react-dom.development.js:732:5)
    at runExtractedEventsInBatch (/Applications/Buckets.app/Contents/Resources/app.asar/node_modules/react-dom/cjs/react-dom.development.js:741:3)
    at handleTopLevel (/Applications/Buckets.app/Contents/Resources/app.asar/node_modules/react-dom/cjs/react-dom.development.js:4198:5)
    at batchedUpdates (/Applications/Buckets.app/Contents/Resources/app.asar/node_modules/react-dom/cjs/react-dom.development.js:12510:14)
    at batchedUpdates (/Applications/Buckets.app/Contents/Resources/app.asar/node_modules/react-dom/cjs/react-dom.development.js:1943:12)
    at dispatchEvent (/Applications/Buckets.app/Contents/Resources/app.asar/node_modules/react-dom/cjs/react-dom.development.js:4279:5)
@iffy iffy added the bug Things that prevent or seriously impede people from doing their budget. label Apr 30, 2018
@iffy iffy added this to the v1.0.0 milestone Apr 30, 2018
@iffy
Copy link
Contributor Author

iffy commented May 3, 2018

I've added more debugging to the log when this error occurs, because I can't mentally reason why it would ever happen.

@iffy
Copy link
Contributor Author

iffy commented May 4, 2018

Got two more of these (could be from the same person)

@iffy
Copy link
Contributor Author

iffy commented May 4, 2018

Also, it seems to be happening in the renderer.

@iffy
Copy link
Contributor Author

iffy commented May 4, 2018

Aha! Steps to duplicate:

  1. Import a CSV
  2. Change a column to some field
  3. Change it back to blank
  4. 2 Errors pop up (hence the double reporting I've been getting)

@iffy iffy added the included in next release The work is done, it's just waiting to be released. label May 4, 2018
@iffy
Copy link
Contributor Author

iffy commented May 7, 2018

Included in v0.43.0 release (AUTOMATED COMMENT)

@iffy iffy closed this as completed May 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Things that prevent or seriously impede people from doing their budget. included in next release The work is done, it's just waiting to be released.
Projects
None yet
Milestone
Buckets v1.0
Development

No branches or pull requests
1 participant
@iffy