Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let me display a currency symbol #107

Closed
iffy opened this issue Apr 25, 2018 · 10 comments
Closed

Let me display a currency symbol #107

iffy opened this issue Apr 25, 2018 · 10 comments
Labels
included in next release The work is done, it's just waiting to be released.

Comments

@iffy
Copy link
Contributor

iffy commented Apr 25, 2018

No description provided.

@iffy
Copy link
Contributor Author

iffy commented Apr 25, 2018

Imported from https://trello.com/c/VjKLOuwe

@cykedev
Copy link

cykedev commented Apr 27, 2018

also, think about number formats

@iffy
Copy link
Contributor Author

iffy commented Apr 27, 2018

@cykedev What kinds of number formats are you hoping for? Currently these ones are supported (via Preferences):

screen shot 2018-04-27 at 9 08 52 am

@Limezy
Copy link

Limezy commented Apr 27, 2018

Cryptocurrency guys could need more digits than that.
Yet I admit there should be very few guys budgeting their ethereums...

@cykedev
Copy link

cykedev commented Apr 27, 2018

@iffy I didn’t see that - so me that’s fine. Thanks

@iffy
Copy link
Contributor Author

iffy commented Apr 27, 2018

Where do you want the currency symbol to be displayed?

  • On every number like this?
    screen shot 2018-04-27 at 4 28 11 pm

  • Or just the ones at the top like this?
    screen shot 2018-04-27 at 4 29 10 pm

  • Or do you just want a big currency indicator next to the month chooser (or somewhere else), like this?
    screen shot 2018-04-27 at 4 33 15 pm

@Limezy
Copy link

Limezy commented Apr 28, 2018

I don't like option 1, it's too much ! (Unless one day we will have two different currencies on the same page, which is not the case for the moment)
I like options 2 and 3. I would say option 2 is the best.

@iffy iffy added the included in next release The work is done, it's just waiting to be released. label May 3, 2018
@iffy
Copy link
Contributor Author

iffy commented May 7, 2018

Included in v0.43.0 release (AUTOMATED COMMENT)

@iffy iffy closed this as completed May 7, 2018
@iffy
Copy link
Contributor Author

iffy commented May 7, 2018

@Limezy @cykedev You can now set your preferred currency symbol in the new "Settings" pane (look on the bottom left of the application)

@Limezy
Copy link

Limezy commented May 14, 2018

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
included in next release The work is done, it's just waiting to be released.
Projects
None yet
Development

No branches or pull requests

3 participants