Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kraken.spot.Trade.create_order: documentatoin for txid outdated. #96

Closed
andyDoucette opened this issue May 20, 2023 · 1 comment · Fixed by #95
Closed

kraken.spot.Trade.create_order: documentatoin for txid outdated. #96

andyDoucette opened this issue May 20, 2023 · 1 comment · Fixed by #95
Assignees
Labels
Documentation Improvements or additions to documentation
Milestone

Comments

@andyDoucette
Copy link

andyDoucette commented May 20, 2023

The documentation states that the result when you create an order has txid as a string:

trade.create_order(
    ordertype="market",
    side="buy",
    pair="XBTUSD",
    volume="0.0001"
)
{
    'txid': 'TNGMNU-XQSRA-LKCWOK',
    'descr': {
        'order': 'buy 4.00000000 XBTUSD @ limit 23000.0'
    }
}

Unfortunately, I'm getting a list, not a string.

The latest Kraken API documentatoin for /private/AddOrder states that txid is:

Transaction IDs for order
(if order was added successfully)

So, I think the documentation for create_order should probably be updated to reflect the fact that txid is now a list.

Thanks! :)

@btschwertfeger
Copy link
Owner

Hey @andyDoucette - you are right! I will adjust this in #95. Thanks too!

@btschwertfeger btschwertfeger added the Documentation Improvements or additions to documentation label May 20, 2023
@btschwertfeger btschwertfeger added this to the v1.3.0 milestone May 20, 2023
@btschwertfeger btschwertfeger self-assigned this May 20, 2023
@btschwertfeger btschwertfeger changed the title create_order() documentatoin for txid outdated. kraken.spot.Trade.create_order: documentatoin for txid outdated. May 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants