Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create kraken.spot.Market.get_asset to use caching #101

Closed
btschwertfeger opened this issue May 20, 2023 · 1 comment
Closed

Create kraken.spot.Market.get_asset to use caching #101

btschwertfeger opened this issue May 20, 2023 · 1 comment
Assignees
@btschwertfeger
Labels
Wontfix This will not be worked on

Comments

@btschwertfeger
Copy link
Owner

Is your feature request related to a problem? Please describe.
There is already an existing kraken.spot.Market.get_assets endpoint which can be used to retrieve all or filtered assets. Since its inputs allow lists, and thus are not hashable, the functools caching cannot be applied. To workaround this, a new function as named in the issue title could be added to archive caching for individual asset pairs.
@btschwertfeger btschwertfeger added enhancement New feature or request Could Something that could be cool bit is not really important Spot Topic related to Spot trading labels May 20, 2023
@btschwertfeger btschwertfeger added this to the v1.3.0 milestone May 20, 2023
@btschwertfeger btschwertfeger self-assigned this May 20, 2023
@btschwertfeger btschwertfeger mentioned this issue May 20, 2023
Merged
@btschwertfeger btschwertfeger linked a pull request May 20, 2023 that will close this issue
Improve caching #102
Merged
@btschwertfeger btschwertfeger removed a link to a pull request May 20, 2023
Improve caching #102
Merged
@btschwertfeger btschwertfeger added Wontfix This will not be worked on and removed enhancement New feature or request Could Something that could be cool bit is not really important Spot Topic related to Spot trading labels May 20, 2023
@btschwertfeger
Copy link
Owner Author

Is not a good solution anymore - see #102.

@btschwertfeger btschwertfeger removed this from the v1.3.0 milestone May 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@btschwertfeger btschwertfeger

Labels
Wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@btschwertfeger