Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Ability to Change Color of Fly-out Features #32

Closed
ddewett opened this issue Jan 11, 2024 · 2 comments
Closed

Feature Request: Ability to Change Color of Fly-out Features #32

ddewett opened this issue Jan 11, 2024 · 2 comments

Comments

@ddewett
Copy link

ddewett commented Jan 11, 2024

Description:

When using custom themes, it is possible to make the background such that the active tab highlights (blue) and the contents drop-down arrows do not have enough contrast to easily see.

Request:

  • Make these agree with the "Secondary Text" and "Primary Text" color or enable changing them directly in the Theme Settings page.
  • Make the example in Theme Settings show these elements.

Screenshot from 2024-01-10 22-24-46

Rationale:

Secondary Text

"Secondary Background" is used for the fly-out background. This is clear to the user by looking at the miniature example given on this screen. However, the tab headings and drop-down arrows are not on this example. Therefore, the user has no idea what these will look like until they navigate to this in the application.

By setting the active tab to the same as "Secondary Text" the UI is color consistent.

Drop-down Arrows

The drop-down arrows have a different color in both provided themes. The user cannot directly control which is used in a custom theme.

The visual improvement of this in the provided themes is minor, and keeping this requires an additional setting in the Theme Settings to accommodate custom themes (either explicitly select this color or toggle between the preexisting two that are available).

Setting this color to the same as "Primary Text" solves all the usability issues at the expense of minor visual changes. The color difference between the arrows in both the provided Light and Dark themes are minor enough that maintaining the same color as the text won't impact usability.

@btpf
Copy link
Owner

btpf commented Jan 11, 2024

I would like to thank you for taking the time to write such detailed reports. Ill try to work through them and aim to push out the next release around the 20th.

@ddewett
Copy link
Author

ddewett commented Jan 11, 2024

👍🏻

@btpf btpf closed this as completed Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants