Fixed bug that caused all tracks to play to channel 1. Thus all track… #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 5, 2022 08:07
…s were played with the instrument in track 1. Fixed bug that caused note outside of track one to never stop. All stop commands were being sent to channel 1. Added an example that was affected by these bugs and now plays correctly.
…in milliseconds and list of events as values. Added percussion class. Updated multiple_instruments.py demo to include percussion. Fixed Note to properly play velocity.
|
there is he same bug with property velocity. I don't understand how this bug can be there since 2 years without any correction an other way to fix it is to replace the following line in Sequencer.play_Note(...) #96 by |
added 7 commits
April 10, 2022 14:07
More updates to keyboard_drumset.py.
…ating player to keep the synth running between changes to code that generates tracks. This is helpful because it takes more than 5 seconds to initialize the synth on my Macbook Pro.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s were played with the instrument in track 1.
Fixed bug that caused note outside of track one to never stop. All stop commands were being sent to channel 1.
Added an example that was affected by these bugs and now plays correctly.