-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow cross compilation under builtin flag #163
base: main
Are you sure you want to change the base?
Conversation
@@ -148,7 +148,7 @@ exclude = [ | |||
# "OCCT/src/BRepCheck/*", | |||
# "OCCT/src/MAT2d/*", | |||
"OCCT/src/ExpToCasExe/*", | |||
# "OCCT/src/STEPControl/*", | |||
"OCCT/src/STEPControl/*", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might have implications on whether or not I can publish to crates.io, we're currently right at the 10MB crate limit. We'll see how it goes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had issues where the STEPControl.hxx headers were missing on windows when it was not included.
@DSchroer I'd be interested in revisiting this - since this PR was opened I have requested a larger crate size for |
I am interested in a working cross compile chain. Any chance to finish this project @DSchroer? If not, I am going to try it ;) |
@fidoriel please do! I'll do my best to help review/test if any PRs are posted. |
To sum up: So, a proper cleanup and squash is needed? I use currently a fork with this patch applied ;) |
@fidoriel yep that sounds about right! |
Fix for #160
occt-sys
no longer builds OCCT in the build.rs file. This allows it to be re-included in the workspace and the build still only triggered when thebuiltin
feature is enabled.This also now passes the correct ENV variables to the build so it is built for TARGET and not HOST.
Finally added CI to test these builds work on various platforms.
Had to rename
Handle_*
toHandle*
for MSVC.