Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using queue interprop as abstraction for queues #35

Open
makasim opened this issue Jan 26, 2018 · 4 comments
Open

Consider using queue interprop as abstraction for queues #35

makasim opened this issue Jan 26, 2018 · 4 comments

Comments

@makasim
Copy link

makasim commented Jan 26, 2018

Hello!

Please look at https://github.com/queue-interop/queue-interop project. Using interfaces from it allows us reuse some implementations like enqueue, which supports a lot of transports. You can outsource some code

@stevenklar
Copy link
Collaborator

As we use the default php library mentioned by rabbitmq themself (php-ampqlib) this might a breaking change and could conflict with future changes.

@makasim Could you give an example which interfaces you would exchange?

@makasim
Copy link
Author

makasim commented Nov 18, 2018

@stevenklar I am talking about amqp-interop interfaces, There are impl for php-amqplib, bunny and amqp-ext.

Please, check official php-amqplib tutorials ported to amqp interop.

@makasim
Copy link
Author

makasim commented Nov 18, 2018

All three mentioned transports support message delaying out of the box, unified ssl configuration and DSN

@stevenklar
Copy link
Collaborator

stevenklar commented Dec 3, 2018

@makasim Would you consider implementing those interfaces and open a pull request?

After a short review this seems like a bigger refactoring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants