Extra launcher when running ember nw:test --server with Ember CLI 1.13.15

[brzpegasus]

When running ember nw:test --server, the testem UI shows two launchers instead of one. This happens upon upgrading to Ember CLI 1.13.15. It does not happen with Ember CLI 1.13.14 or below.

[brzpegasus]

Clarification: This behavior is seen when upgrading Ember CLI in the consuming app, not in the addon.

[brzpegasus]

Pinpointed the issue to this specific commit in testem.

[felixrieseberg]

One thing that is worth pointing out: When @sedouard and I worked on the app that lead to some of the testing and Qunit code, we saw a bunch of testing wonkiness, but it ultimately still reports correctly.

(Just in case anyone looks at this and thinks that the feature is broken - it's just visually broken 😉)

[brzpegasus]

I cleaned up a lot of things with the testing command, so I'm not aware of any leftover testing wonkiness in particular (though I'd like to know if there are any). Having two launchers show up in the UI seems to be a result of Testem refactoring the code to consolidate Dev + CI modes. There used to be only one prior to upgrading Testem. Right now, the first tab never runs any tests and shouldn't be there. The 2nd tab is correct. It's not preventing users from getting to the results by focusing on the right tab, but still annoying =).

[felixrieseberg]

Nevermind then, if you cleaned it up it's probably all fine 😊When we initially worked on it, testem (interactive) would sometimes just be the grinch (and display things all over the place, have multiple launchers, launch nwjs repeatedly, etc), but the end results we're always correct.