Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifying an object with a Fixme icon triggers display of quests, even when quests are disabled #806

Closed
jmapb opened this issue Aug 12, 2024 · 1 comment

Comments

@jmapb
Copy link

jmapb commented Aug 12, 2024

  • iPhone SE (2nd generation)
  • iOS 17.5.1 (21F90)
  • GoMap!! 4.3.0

Steps to reproduce:

  1. Toggle off Quests overlay (but leave individual quests toggled on)
  2. Toggle on Notes and Fixmes overlay
  3. Locate and select an object with a Fixme icon
  4. Make any change that leaves the fixme-tagged object in a state that would trigger a quest, eg:

One noteworthy quirk is that this behavior happens even if the blue "F" Fixme icon is not currently showing. The fixme tag can be removed or the Notes and Fixmes overlay can be toggled off, and the unwelcome quest mode can still be triggered -- as long as the object in question had a Fixme icon earlier in the editing session.

@jmapb jmapb changed the title Removing fixme tag from POI shows quests, even when quests are disabled Modifying an object with a Fixme icon triggers display of quests, even when quests are disabled Aug 18, 2024
@bryceco
Copy link
Owner

bryceco commented Sep 26, 2024

This behavior isn't actually related to FixMe's. Any edit to the object would cause it to rerun the Quest evaluation code on the object, ignoring that quests were disabled globally. Thanks for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants