Minor refactoring based on static analysis on the code of images: (py…

…torch#2891) - Replace deprecated string.h with cstring. - Switch to nullptr.
bryant1410 · Nov 22, 2020 · a1dada2 · a1dada2
1 parent 24337cb
commit a1dada2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/torchvision/csrc/cpu/image/read_image_cpu.cpp b/torchvision/csrc/cpu/image/read_image_cpu.cpp
@@ -1,5 +1,5 @@
 #include "read_image_cpu.h"
-#include <string.h>
+#include <cstring>
 
 torch::Tensor decode_image(const torch::Tensor& data) {
   // Check that the input tensor dtype is uint8

diff --git a/torchvision/csrc/cpu/image/read_write_file_cpu.cpp b/torchvision/csrc/cpu/image/read_write_file_cpu.cpp
@@ -46,7 +46,7 @@ void write_file(std::string filename, torch::Tensor& data) {
   auto fileCStr = filename.c_str();
   FILE* outfile = fopen(fileCStr, "wb");
 
-  TORCH_CHECK(outfile != NULL, "Error opening output file");
+  TORCH_CHECK(outfile != nullptr, "Error opening output file");
 
   fwrite(fileBytes, sizeof(uint8_t), data.numel(), outfile);
   fclose(outfile);