Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use plan name and search on repo git tags to find potential versions #18

Closed
pharr117 opened this issue Sep 9, 2023 · 0 comments · Fixed by #19
Closed

Use plan name and search on repo git tags to find potential versions #18

pharr117 opened this issue Sep 9, 2023 · 0 comments · Fixed by #19

Comments

@pharr117
Copy link
Contributor

pharr117 commented Sep 9, 2023

We currently do a naive regex search on the string dump of the entire plan when trying to find version numbers. We should attempt to do the following instead:

  1. Get the plan name, these are usually of the form "v"
  2. Search the git tags in the associated chain repo
  3. Find all matching tags that have the plan name version number in them
  4. Return the "best" match (or the closest match that can be made)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant