Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Further Improvements #208

Merged
merged 10 commits into from
Aug 16, 2022
Merged

[UX] Further Improvements #208

merged 10 commits into from
Aug 16, 2022

Conversation

brxken128
Copy link
Owner

This implements the changes specified in #204.

A lot of print statements have been removed, and I feel as though I prefer it this way as it matches other command-line applications.

Most command-line applications don't print to the console unless they've errored, and I feel that's a good thing to stick by.

Obviously this is very subjective, so feel free to object :)

@brxken128 brxken128 requested a review from pleshevskiy August 15, 2022 10:50
@brxken128 brxken128 marked this pull request as draft August 15, 2022 10:50
@brxken128 brxken128 marked this pull request as ready for review August 15, 2022 11:26
@brxken128
Copy link
Owner Author

@pleshevskiy I removed the Deoxys feature. The feature was probably a bad idea as it needed to be enabled in order to decrypt files that were encrypted with Deoxys.

I'm still not going to add the support to encrypt with it (although I will do some testing to see how performance is doing), but we still need to provide the option to decrypt with it.

I also removed the visual feature by default, as this should clean CLI output up a lot as well. My goal is to make Dexios more UNIX-like, and only alert the user to something where it's required.

@pleshevskiy
Copy link
Contributor

LGTM!

@brxken128 brxken128 merged commit 33cc04f into master Aug 16, 2022
@brxken128 brxken128 deleted the issue-204 branch August 16, 2022 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants