cli: some improvements for password #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will probably fix brxken128#103, but I can't check it.
brxken128
reviewed
Jul 13, 2022
| #[cfg(target_family = "windows")] | ||
| let input = | ||
| read_password_from_stdin_windows("Password: ").context("Unable to read password")?; | ||
| let input = read_password_from_stdin("Password: ").context("Unable to read password")?; |
There was a problem hiding this comment.
I had no clue this could be determined dynamically, that's awesome!
brxken128
reviewed
Jul 13, 2022
| @@ -98,14 +89,20 @@ pub fn get_password(pass_state: &PasswordState) -> Result<Protected<Vec<u8>>> { | |||
| // this passphrase should provide adequate protection, while not being too hard to remember | |||
| pub fn generate_passphrase() -> Protected<String> { | |||
| let collection = include_str!("wordlist.lst"); | |||
| let words = collection.split('\n').collect::<Vec<&str>>(); | |||
| let words = collection.lines().collect::<Vec<_>>(); | |||
There was a problem hiding this comment.
Does this automatically strip the newline from the end of the word? If so, that's pretty cool. I can spin up a VM and give it a test too :)
There was a problem hiding this comment.
Yes, because lines uses split_terminator under hood
|
Nice work as usual my friend, thank you so much for all of these improvements! |
|
I believe this did fix #103 - it seems to work now at least. Good catch :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will probably fix #103, but I can't check it.