Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPP v7.5.8 has new directory structure for plugins, so Plugin Manager shows no installed plugins #127

Open
pryrt opened this issue Sep 11, 2018 · 9 comments

Comments

@pryrt
Copy link

pryrt commented Sep 11, 2018

While looking at #126, I did a fresh portable NPP 7.5.8 64-bit and added \usr\local\apps\npp64.7.5.8\plugins\PluginManager\PluginManager.dll. Debug Info shows 4 plugins, and Plugin Manager properly runs from the new subfolder of plugins:

Notepad++ v7.5.8   (64-bit)
Build time : Jul 23 2018 - 02:06:36
Path : C:\usr\local\apps\npp64.7.5.8\notepad++.exe
Admin mode : OFF
Local Conf mode : ON
OS : Windows 10 (64-bit)
Plugins : DSpellCheck.dll mimeTools.dll NppConverter.dll PluginManager.dll 

but Plugins > Plugin Manager > Show Plugin Manager > Installed shows "There are no known installed plugins".

Looking at my installed v7.5.8 32-bit,

Notepad++ v7.5.8   (32-bit)
Build time : Jul 23 2018 - 02:03:53
Path : C:\Program Files (x86)\Notepad++\notepad++.exe
Admin mode : OFF
Local Conf mode : OFF
OS : Windows 10 (64-bit)
Plugins : ComparePlugin.dll dbgpPlugin.dll MarkdownViewerPlusPlus.dll NppExec.dll NppFTP.dll PluginManager.dll PreviewHTML.dll PythonScript.dll XMLTools.dll DSpellCheck.dll mimeTools.dll NppConverter.dll NppExport.dll 

... Debug info shows 13 (if I counted correctly),. but the Plugin Manager > Installed list only shows some of them: Compare, DBGp, MarkdownViewer++, NppExec, NppFTP, Plugin Manager, Preview HTML, Python Script, and XML Tools -- it's just the ones that don't have the DLL in a subfolder of plugins.

(I thought I had seen something similar in the forums at some point recently, but a quick search didn't find it for me)

For Plugin Manager to be compatible going forward from v7.5.8, it's going to need to understand the hierarchical plugin installations as well as recognizing the ones in the main plugins\ folder.

@BannerBomb
Copy link

I am getting something similar as well. Opening Plugin Manager says it is loading the plugins list but then says No new plugins available under the Available tab.

@chcg
Copy link
Collaborator

chcg commented Sep 12, 2018

@pryrt @BannerBomb PluginManager doesn't support the new structure introduced by N++ with 7.5.8 yet. Just the plugin dlls directly placed inside the plugins folder are found and listed.

chcg added a commit to chcg/nppPluginManager that referenced this issue Sep 30, 2018
…lugin search in subdirs

- updated appveyor.yml to use v140_xp and VM image VS2017
@chcg chcg added this to the v1.4.12 milestone Sep 30, 2018
@chcg chcg mentioned this issue Sep 30, 2018
chcg added a commit that referenced this issue Sep 30, 2018
* - switch appveyor.yml to VM with vs2017, changed build toolchain to vs2015

* - add fix for issue #127 to support N++ 7.5.8 feature of plugin search in subdirs
- updated appveyor.yml to use v140_xp and VM image VS2017
@alexhass
Copy link

This patch has a bug. If You had your plugin in a subfolder and there is an update e.g. NppConverter.dll 4.2.0 is updated to 4.2.1 it will be updated to plugins\NppConverter.dll and not plugins\NppConverter\NppConverter.dll.

Can you fix this bug and release a new version, please?

@chcg
Copy link
Collaborator

chcg commented Oct 21, 2018

I wouldn't consider this as a bug, but a compatibility feature. Otherwise PM would need to provide a version specific install routine based on the N++ version and the developers would need to test two installation modes, if the plugin is not just a simple single dll.

But there are still some bugs in this first simple adaption to the changed/extended behaviour of N++ plugin handling (done to prepare for a buildin plugin management to my knowledge).

@de-served
Copy link

de-served commented Nov 15, 2018

After plugin installation/reinstallation by PM these "(re)installed" plugins are invisible, because *.dll's placed in the root of plugins/ directory. NPP 7.6 sees plugins only in subfolders of plugins/. I lost a lot of time to understand what happens and where are all plugins gone after mass "reinstall" on all plugins (updated NPP and tried to recover plugin files/structure).
So now in 7.6 plugins must be in subdirectory in plugins/ directory. Name of that subdirectory is important and must be as dll name:
plugins/3P/3P.dll + NetFrameworkChecker.exe
BetterMultiSelection/BetterMultiSelection.dll
CsvQuery/CsvQuery.dll
etc.

@chcg
Copy link
Collaborator

chcg commented Nov 16, 2018

@desirepl
Did you see https://notepad-plus-plus.org/news/notepad-7.6-released.html
and https://notepad-plus-plus.org/features/plugin-admin.html.
There is still much discussion(see e.g. https://notepad-plus-plus.org/community/topic/16621/notepad-7-6-new-plugins-admin) on this, so maybe some further adaptations/changes are still needed.
So it is unclear if PM will be modified to work together with this changes. At least not before the changes have stabilized.

@dartraiden
Copy link

dartraiden commented Nov 26, 2018

So now in 7.6 plugins must be in subdirectory in plugins/ directory

Under Windows, plugins now can be loaded only from /AppData/Local/, so PluginManager should not place them to /AppData/Roaming/

@de-served
Copy link

de-served commented Nov 26, 2018

So now in 7.6 plugins must be in subdirectory in plugins/ directory

Under Windows, plugins now can be loaded only from /AppData/Local/, so PluginManager should not place them to /AppData/Roaming/

My plugins are not in %AppData% at all. Notepad installed in custom directory and inside notepad directory there are "localisation", "themes", "updates" and... "plugins"! Now all my plugins, each of them, are placed inside that "plugins" directory and each plugin has its own directory named as plugin ".dll".
@chcg, read links. Waiting for stabilization.

@alexhass
Copy link

Files always need to be installed to Roaming. Never to AppData/Local as this folders are typically excluded from roaming and therefore deleted when a user logs off from his computer (with roaming user profiles)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants