Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust upstream binaryen methods for const-correctness #122

Open
brson opened this issue Dec 7, 2022 · 1 comment
Open

Adjust upstream binaryen methods for const-correctness #122

brson opened this issue Dec 7, 2022 · 1 comment
Milestone
M3

Comments

@brson
Copy link
Owner

brson commented Dec 7, 2022

Related to #104. I still am unconvinced to implement that because it makes the code a bit uglier, and the patterns we are using now work for us.

We could also go upstream and make binaryen methods const-correct, which would let us use the most correct patterns in the bindings.
@brson brson added this to the M3 milestone Dec 7, 2022
@brson
Copy link
Owner Author

brson commented Dec 8, 2022

Probably the thing to do is spend a small amount of time seeing how many changes are necessary to convert our bindings to be const-correct, and if that seems reasonable, file an issue upstream about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
M3
Development

No branches or pull requests
1 participant
@brson