Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust shim patterns for incorrect const-correctness #104

Open
brson opened this issue Oct 17, 2022 · 1 comment
Open

Adjust shim patterns for incorrect const-correctness #104

brson opened this issue Oct 17, 2022 · 1 comment
Milestone
M3

Comments

@brson
Copy link
Owner

brson commented Oct 17, 2022

In #95 dtolnay provides a better shim pattern for dealing with non-const-correct APIs.

It is a breaking change and needs to wait for a major version bump.
@brson brson added this to the M3 milestone Oct 17, 2022
@brson brson mentioned this issue Oct 17, 2022
Closed
@brson brson modified the milestone: M3 Nov 11, 2022
@brson
Copy link
Owner Author

brson commented Nov 11, 2022

I am undecided yet about whether to actually do this, as the pattern we have now is fine for our purposes, and the suggested pattern requires using C++ free functions instead of methods.

@brson brson mentioned this issue Dec 7, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
M3
Development

No branches or pull requests
1 participant
@brson