Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cba-actions component #44

Open
Manvel opened this issue Mar 26, 2021 · 0 comments
Open

cba-actions component #44

Manvel opened this issue Mar 26, 2021 · 0 comments
Labels
good first issue Good for newcomers

Comments

@Manvel
Copy link
Member

Manvel commented Mar 26, 2021

Background

For the new CBA UI, we need to introduce new cba-actions component as shown in the image below:

Screen Shot 2021-03-26 at 4 55 13 PM

For the project it might be wise to reuse already implemented cba-table component and ideally migrate to using <ul> instead of <table>, to be consistent with other elements and simplicity(can be done separately).

What to change

Implement new cba-actions by extending the existing cba-table component.

Additional info

  • The new cba-actions component should mostly be WCAG compliant.
  • Keyboard naviations, reordering, dragNdrop and other similar implementation details are covered already by cba-table, so when in doubt about implementation, please refer to it first and ensure no regression is provided regarding existing functionality.
  • Add cba-select component to the event cells.
    • select the event provided in data model for specific action.
    • on change event update event type for the item the change was fired for.
  • On hover or when action item is selected current control items should appear:
    • Edit(edit icon in UI screenshot) - Clicking item opens prepopulated popup by input1(data in old version) and input2(value in old version).
      • Screen Shot 2021-05-02 at 5 10 53 PM
      • Clicking confirm button or focusing and hitting Enter closes popup, saves changes for action and triggers change event on cba-actions component.
      • Clicking cancel button or focusing and hitting Enter closes popup.
    • Add action(+ icon)
      • adds action right below the targeted one trigger change event on cba-actions component.
    • Kebab menu
      • opens cba-menu with item below:
        • Delete - deletes current action and trigger change event on the cba-actions component.
  • Hitting Delete button on selected action should delete action trigger change event.
  • Hitting Enter button on selected action should open cba-popup.
  • Hitting tab on selected item should first focus on cba-select -> edit button -> add button -> kebab -> navigate out of the component.
  • Ignore target icon that is in between of edit and add in the screenshot - we don't have yet functionality for that

Tests

  • Ensure to create smoke test with information about how to use the component.
  • Ensure that the functionality explained above are covered by puppeteer where possible(i.e. custom methods, parameters, keyboard and mouse navigation and etc.).
@Manvel Manvel changed the title Using buttons on cba-table row buttons and kebab menu support for cba-table row Mar 26, 2021
This was referenced May 2, 2021
@Manvel Manvel changed the title buttons and kebab menu support for cba-table row cba-actions component May 2, 2021
@Manvel Manvel added the good first issue Good for newcomers label May 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant