Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Django package tests fail with django_find_project = false #851

Closed
2 tasks done
abe-101 opened this issue Dec 29, 2024 · 2 comments · Fixed by #857
Closed
2 tasks done

Bug: Django package tests fail with django_find_project = false #851

abe-101 opened this issue Dec 29, 2024 · 2 comments · Fixed by #857
Labels
bug Something isn't working

Comments

@abe-101
Copy link

abe-101 commented Dec 29, 2024

Describe the bug

When creating a new package and answering "yes" to "Is this a Django package?", the template adds django_find_project = false to pyproject.toml which causes tests to fail.

To Reproduce

  1. Create new package using the template
  2. Answer "yes" when asked if it's a Django package
  3. Run tests

Additional context

No response

Version

current

Platform

Fedora

Code of Conduct

  • I agree to follow this project's Code of Conduct.

No Duplicate

  • I have checked existing issues to avoid duplicates.
@abe-101 abe-101 added the bug Something isn't working label Dec 29, 2024
@browniebroke
Copy link
Owner

Just tested again and not sure why I needed that in the first place. As far as I remember, it was failing with tox + poetry without it, but it seems like it's all good now 🤷🏻

@browniebroke
Copy link
Owner

Ok I got it. That's because there was no manage.py at the time. I tried to removedjango_find_project from one of my other projects and it failed, because unlike this template, the project had no manage.py in the root.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants