fix: allow ReactNode type for title and caption
#1140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`string` is already part of the `ReactNode` union type, so this change works
|
Thanks for the fix. Do you think you could write a small test for that? Would be useful to make sure this case isn't missed in the future... You can take example to the existing tests. It doesn't have to be too involved. |
|
Ok, scratch that suggestion from before. These properties aren't test at the moment, because we don't test the component with the state |
browniebroke
changed the title
ReactNode type for title and caption
|
Thanks for the fix 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stringis already part of theReactNodeunion type, so this change works