Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: LOCK_8502 and LOCK_8506 shares the same ID (180) #355

Closed
lenoxys opened this issue Aug 9, 2023 · 2 comments
Closed

[Bug]: LOCK_8502 and LOCK_8506 shares the same ID (180) #355

lenoxys opened this issue Aug 9, 2023 · 2 comments
Assignees
Labels
bug Something isn't working fixed

Comments

@lenoxys
Copy link
Contributor

lenoxys commented Aug 9, 2023

Client version

2.7.1

Node version

18.17.0

Operating System type

Linux

Operating system version

Debian 11

Describe the bug

Hello @bropat,

how are you ? Found this one while publishing into npm.

LOCK_8502 and LOCK_8506 shares the same ID (180)

It shouldn't be the case.

https://github.com/bropat/eufy-security-client/blob/master/src/http/types.ts#L66

@lenoxys lenoxys added the bug Something isn't working label Aug 9, 2023
@lenoxys lenoxys changed the title [Bug]: [Bug]: LOCK_8502 and LOCK_8506 shares the same ID (180) Aug 9, 2023
@bropat
Copy link
Owner

bropat commented Aug 9, 2023

@lenoxys

Yes, I know, I took it over from the app.
Since I haven't had these devices in my hands yet, I don't know if it's a mistake or if they both effectively have the same ID...
Thanks anyway for the advice. :)

@justinlindh
Copy link
Contributor

@bropat - T8506 uses 184; patched in my PR, here: #377

@bropat bropat added the fixed in next version Fixed in the code of the next release label Oct 6, 2023
@bropat bropat self-assigned this Oct 6, 2023
@bropat bropat added fixed and removed fixed in next version Fixed in the code of the next release labels Nov 4, 2023
@bropat bropat closed this as completed Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed
Projects
None yet
Development

No branches or pull requests

3 participants