Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for build command artifacts to populate by adjusting filter for data:args:which = 'run' #78

Closed
mrevelo-clickup opened this issue Feb 1, 2022 · 3 comments

Comments

@mrevelo-clickup
Copy link

mrevelo-clickup commented Feb 1, 2022

I recently implemented this package and it has been working great; however, we recently switched away from dbt run to dbt build. In doing so, I noticed that artifacts were no longer being parsed out into the fact and dimension models during a dbt_artifacts run despite being in the dbt_artifacts table.

Upon investigation, the model execution and run results models have a filter to limit the artifacts to those which are from run commands only, and not builds. I propose the filter be adjusted to data:args:which in ('run', 'build') for these models (or at least do the reverse and filter out non-run commands for future scalability):

  • stg_dbt__model_executions.sql
  • stg_dbt__run_results
  • stg_dbt__run_results_env_keys

Unless there is a reason in particular while builds are not included - please let me know. Thanks!

@NiallRees
Copy link
Contributor

Hi @mrevelo-clickup, thanks for this write-up and the solution proposed. It sounds great to me :)

@mrevelo-clickup
Copy link
Author

Only other concern is that the models may need to be re-architected around the build command since it packages together tests, snapshots, etc. Unless they are run as their own commands, I don't think they will get parsed out into their relevant test and snapshot models. Will push through the easy change to include build for now to get over the hump.

@alanmcruickshank
Copy link
Contributor

@NiallRees I think this can be closed given #85 should fix the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants