Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SurfingKeys] Error found in settings: TypeError: Hints.setCharacters is not a function - after most recent update #2155

Closed
Stvad opened this issue Sep 17, 2024 · 6 comments

Comments

@Stvad
Copy link
Contributor

Stvad commented Sep 17, 2024

Error details

SurfingKeys: 1.17.0

Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/128.0.0.0 Safari/537.36

URL: any

Context

I have the following line in my settings:
Hints.setCharacters('arstdqwfpgzxcvbneiouym')

and that started throwing an error after the latest update

@clarkwang
Copy link

@nathanielescribano
Copy link

nathanielescribano commented Sep 18, 2024

I'm hitting a similar issue with setNumeric.
[SurfingKeys] Error found in settings: TypeError: Hints.setNumeric is not a function

Looks like it's still a function when i pulled the repo, but not sure if that's whats deployed in the chrome extension store.
(using brave btw)

Any help would be appreciated!

@allamedo
Copy link

Seems like it can be temporarily fixed with this: #1821 (comment)

@NoRePercussions
Copy link

Watch out -- it doesn't look like this is a fix. Since api.Hints.setCharacters, is not exported, this actually creates a new variable, which is never used. It is effectively equivalent to just removing that line.

@clarkwang
Copy link

Watch out -- it doesn't look like this is a fix. Since api.Hints.setCharacters, is not exported, this actually creates a new variable, which is never used. It is effectively equivalent to just removing that line.

Right. See Brook's comment here: #1821 (comment)

@brookhong
Copy link
Owner

Fixed in 1.17.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants