Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When looking up a types, check hasOwnProperty #23

Closed
thejh opened this issue Dec 24, 2011 · 4 comments
Closed

When looking up a types, check hasOwnProperty #23

thejh opened this issue Dec 24, 2011 · 4 comments
Assignees

Comments

@thejh
Copy link

thejh commented Dec 24, 2011

When looking up a types, check hasOwnProperty - we don't want to pretend that __defineGetter__ is a valid file extension whose MIME type is a function.

@ghost ghost assigned broofa Dec 25, 2011
@broofa
Copy link
Owner

broofa commented Dec 25, 2011

Is this causing problems in real code, or is this merely a theoretical concern at this point?

@thejh
Copy link
Author

thejh commented Dec 25, 2011

Well, e.g. this HTTP response looks somewhat unclean: https://gist.github.com/84464a405a7018066428 - however, I don't know any way to exploit this or a case in which this causes much trouble.

@broofa
Copy link
Owner

broofa commented Dec 25, 2011

Seems like the tradeoff is the microscopically small difference in code legibility and size .vs. the even smaller chance this will ever matter in real-world code. I don't feel strongly enough to want to change things, but I'll leave this open if anyone else wants to weigh in.

@broofa
Copy link
Owner

broofa commented Feb 14, 2012

Resolving in #24

@broofa broofa closed this as completed Feb 14, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants