-
-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't be a pain in the ass for node community #108
Comments
Apologies accepted, no worries. :) I wouldn't say mime-types exists solely because it was not updated. The goal was to avoid the I would give Specifically, everything is built on top of cc @dougwilson also |
That is up to you.
In the interest of community control + openness, we would keep mime-types in jshttp (a multiple-owner github org). Minus the fact that the API is different of course. :) |
happy thanksgiving! some options are:
these are the only solutions i can think of. we won't be abandoning |
In addition, no one says there cannot be two mime type libraries... |
@broofa Again, the API is different. If anything, I'd recommend using |
@Fishrock123 Given that the original motivation of #61 was to make this compatible with Browserify (i.e. run in-browser), does it really make sense to switch to |
You could always do a build here that only leaves types with extensions and strips the rest. :) |
Circular dependencies make me dizzy. ;) |
It comes from three sources:
I'm just answering this, but I really have no opinion about what happens here. I don't see any true reason why there cannot be two different mime libs. If this library were to start using |
I'm interested (and created: https://github.com/Hypercubed/node-mime) a library that can do this:
https://github.com/jshttp/mime-types cannot do that and has |
Why do you, @broofa, have to be the only author of Anwyay, I'm glad I stopped by! While we don't need what @Hypercubed adds, and I'm not too keen on the general concept of the proliferation of mime-types, release valves (a term I just learned from @loudwinston) are awesome because its not cool to make it harder for developers to do what they need to. UPDATE: I had originally included "when appropriate" to describe release valves in the context of adding custom mime types, and regret the removal. Because: https://github.com/jshttp/mime-db#adding-custom-media-types |
@docunext I'm not sure what you mean by valves. My proposal in #129 was to separate the lookup API from the mime-db itself, it had nothing to do with adding types. The mime-db large. If I use node-mime in the browser, and I did for some time, it to too much to send over the wire. https://github.com/Hypercubed/mime-lookup is a fork of node-mime that provides just the API. The database can be then entire mime-db (https://github.com/Hypercubed/mime-lookup#using-mime-db) or a subset as I have done here: https://github.com/Hypercubed/Project-Chi/blob/master/app/common/services/datapackage/mime.js |
Hey all, thanks for the comments and, more importantly, your patience. @docunext - I don't have to be the only contributor to this repository. It's more that there's never really been an obvious person to hand responsibility off to. I'm open to suggestions, especially if you have someone in mind who has a demonstrated ability to responsibly shepard a library that a lot of projects depend on. |
Closing this out as node-mime is sits on mime-db now. |
All, I've been a bit of an absentee landlord as far as maintaining this library goes. My response time on issues has been horrid, and that https://github.com/jshttp/mime-types exists is testament to the poor job I've been doing. For this I humbly apologize.
Moving forward, I'd like to insure this isn't an issue. So... What's the right thing to do here? Are there parties interested in being added as maintainers? (If so, who?) Should this library be deprecated in favor of mime-types? Could mime-types be pulled in here?
Hopefully I haven't completely alienated everyone. I'm genuinely interested in hearing everyone's opinions, and willing to do whatever the community thinks is best.
cc: @dominictarr @Fishrock123 @substack @jonathanong
The text was updated successfully, but these errors were encountered: