-
-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
To consider removing NavigatorUAData.getHighEntropyValues() #1781
Comments
Hiding the browser version is not a goal of Bromite and it is not possible anyways because of the adblock filters.
The client hint for model was disabled here: https://github.com/bromite/bromite/blob/master/CHANGELOG.md#9304577110 So we could also disable this one, or provide a dummy version. |
perfect, I'll do so.
ok
can you explain to me why? |
It is possible to verify which ad filters are present by checking what resources do not get loaded. This allows to detect Bromite; it is not a secret and was discussed in multiple places; it is also the reason why Bromite does not try to look like any other browser. |
sure, i understand this, but the goal of the reduced ua was to not make people understand what the build version is for any unresolved security flaws? |
Which reduced UA are you referring to, specifically? |
w3ctag/design-reviews#640 |
Out of the list in https://developer.mozilla.org/en-US/docs/Web/API/NavigatorUAData/getHighEntropyValues |
You could also just always reject the Promise for any high-entropy hints you don't wish to support (or all of them). See step 2 in https://wicg.github.io/ua-client-hints/#getHighEntropyValues |
That sounds indeed like the correct way to handle this. |
I have been checking the Chromium code about this; it currently does not implement any Until that I opt for providing fake values, which is consistent with past/current Bromite behavior and should reduce client-side breakage (there is currently no way to say Note: in Chromium the feature policy for client hints has been removed: chromium/chromium@9b85b2a |
Yep, that's correct. |
@uazo the headers part is now addressed, what is the behaviour of the Javascript side when headers are not provided? |
about what?
yes, we could return the same version of the header instead of the complete one |
Ok, let's go with that for now. Do you want to make a PR or shall I? |
the first thing I have to do is merge my branch with yours, then I do. |
Please open a PR for it. |
Is your feature request related to privacy?
Yes
Is there a patch available for this feature somewhere?
No, but it's trivial
Describe the solution you would like
since even with ua reduction it is possible to obtain the browser version (see https://developer.mozilla.org/en-US/docs/Web/API/NavigatorUAData/getHighEntropyValues) is perhaps better completely remove the method from the idl
Describe alternatives you have considered
removing the method could lead to unmanaged errors in scripts. While it may be fair from a privacy standpoint, we may break some sites.
the alternative is to delete only the uaFullVersion
The text was updated successfully, but these errors were encountered: