Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] assemble_denovo fails at larger ANI distance #543

Closed
dpark01 opened this issue Jun 21, 2024 · 1 comment
Closed

[bug] assemble_denovo fails at larger ANI distance #543

dpark01 opened this issue Jun 21, 2024 · 1 comment

Comments

@dpark01
Copy link
Member

dpark01 commented Jun 21, 2024

After incorporating reference selection changes in #528, the workshop exercise of LASV assembly now fails for two samples that it did not previously fail on. This is because the example data against the supplied reference genomes is too far for skani to hit, and the resulting skani dist output is empty, resulting in CHOSEN_REF_FASTA being unset.

The reference selection code in task assembly needs to have a sensible fallback behavior (perhaps the pre-#528 behavior or maybe something mummer or minimap2 based) in the scenario when the skani dist output is empty. The error mode shouldn't happen, and even if it did, the error messages are cryptic.

@dpark01
Copy link
Member Author

dpark01 commented Aug 19, 2024

closed by #547

@dpark01 dpark01 closed this as completed Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant