Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Funcotator - review and finalize data sources release numbers / versioning #4582

Closed
jonn-smith opened this issue Mar 26, 2018 · 2 comments
Closed
Assignees
Milestone

Comments

@jonn-smith
Copy link
Collaborator

Need to look at how to version the releases of data sources and individual data sources.

This is exemplified with the dbSNP common vs dbSNP All problem.

@jonn-smith jonn-smith added this to the Engine-2Q2018 milestone Mar 26, 2018
@jonn-smith jonn-smith changed the title Funcotator - review an finalize data sources release numbers / versioning Funcotator - review and finalize data sources release numbers / versioning Apr 3, 2018
@jonn-smith jonn-smith self-assigned this May 15, 2018
@jonn-smith
Copy link
Collaborator Author

#4692 should be fixed in conjunction with this.

@jonn-smith
Copy link
Collaborator Author

We determined that dbSNP should have the all data.

Individual data sources will be versioned as well as the Broad-provided packages.

Broad-packaged data sources will be semantic versioned (see https://semver.org/) with the patch version corresponding to the date of release and any decorators on the data.

A decorator is an arbitrary string that adds information to the version. For instance, two data source releases may contain several overlapping data sources and some use-case specific ones (such as in the germline and somatic uses of the tool). For these two data source releases, they will have the same version number, but with different decorators.

Concretely:
funcotator_dataSources.v1.4.20180829g.tar.gz - germline data sources
funcotator_dataSources.v1.4.20180829s.tar.gz - somatic data sources

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant