Migrate to React 15.5

[ghost]

Why?

• React 15.5 was released, causing some changes in light of React Fiber coming
• even though react is a peer dependency for this project (as you correctly state in Update to React 15.5  #67), some of the internal code for the library itself relies on old versions of React.
• From the React blog:

we've extracted React.PropTypes and React.createClass into their own packages. Both are still accessible via the main React object, but using either will log a one-time deprecation warning to the console when in development mode.

Adding new warnings is not something we do lightly. Warnings in React are not mere suggestions — they are integral to our strategy of keeping as many people as possible on the latest version of React.

So while the warnings may cause frustration in the short-term, we believe prodding developers to migrate their codebases now prevents greater frustration in the future. Proactively fixing warnings ensures you are prepared for the next major release. If your app produces zero warnings in 15.5, it should continue to work in 16 without any changes.

What?

Prop-Types

• migrates React.PropTypes to prop-types package using the codemod
• makes prop-types a dependency as recommended by React

CSS Transition Group

• migrates react-addons-css-transition-group to react-transition-group

Enzyme

• updates enzyme which supports using the new react-dom/test-utils instead of old react-addons-test-utils

Question:

• the one item i'm not 100% sure on is this line. I see the Webpack config is excluding the CSS Transition Group from including React in the build as described here. But I'm not sure the root property is the right way to do it.

What are your thoughts on this @brijeshb42 ?

[codecov-io]

Codecov Report

Merging #73 into master will increase coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
+ Coverage    86.2%   86.25%   +0.04%     
==========================================
  Files          15       15              
  Lines         319      320       +1     
  Branches       42       42              
==========================================
+ Hits          275      276       +1     
  Misses         44       44

Impacted Files	Coverage Δ
src/components/entities/link.js	92.3% <100%> (+0.64%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f715d3b...fd6cff6. Read the comment docs.

[brijeshb42]

@baldwmic I build the files as UMD. So root property is used for exposing to window global. It should remain

['React', 'addons', 'CSSTransitionGroup']

because I just checked the latest build from https://unpkg.com/[email protected]/dist/react-with-addons.js and it has React.addons.CSSTransitionGroup.

[brijeshb42]

@baldwmic I will take a look this PR and merge. It may take some time.

[ghost]

@brijeshb42 i've updated the PR per your comment about the build.

Thanks for taking a look and let me know if I've missed anything!

[brijeshb42]

Can you change this to

  {
      'react-transition-group/CSSTransitionGroup': {
        root: ['React', 'addons', 'CSSTransitionGroup'],
        commonjs2: 'react-transition-group/CSSTransitionGroup',
        commonjs: 'react-transition-group/CSSTransitionGroup',
        amd: 'react-transition-group/CSSTransitionGroup',
      }
    }

Otherwise the whole package is included in the build file which significantly increases the file size.

Everything else looks good and I'll merge once the changes are done.

[ghost]

@brijeshb42 I've updated the PR per your comment

[ghost]

definitely wouldn't want to increase build size unnecessarily

[ghost]

@brijeshb42 yup! just updated the PR

[brijeshb42]

@baldwmic Just published v0.5.1 after merging your PR.