Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove global browserify transforms, and call as needed instead #48

Merged
merged 1 commit into from
Apr 3, 2017

Conversation

brandonocasey
Copy link
Contributor

This fixes instances where this package will be used as a dependency in projects that use browserify on it.

@gkatsev
Copy link
Member

gkatsev commented Apr 3, 2017

If we want, we can do the version update via babel. See the videojs and videojs-flash babel RCs.

@brandonocasey
Copy link
Contributor Author

Sure I will work on that

@brandonocasey
Copy link
Contributor Author

brandonocasey commented Apr 3, 2017

actually that would entail updating this projects to babel 6. I think that we probably hold off on that and update this plugin to new generator standards in another PR instead.

@gkatsev
Copy link
Member

gkatsev commented Apr 3, 2017

Sounds good.

@brandonocasey brandonocasey merged commit aa74853 into master Apr 3, 2017
@brandonocasey brandonocasey deleted the fix/no-pkg-browserify-transforms branch April 3, 2017 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants