Change codes of recently-added errors and allow type and code to be shared. #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Changed the codes of recently-added errors; so, they will work with 1.x implementations.
misteroneill
changed the title
misteroneill
force-pushed
the
rename-new-custom-errors
branch
from
4df05ab to
713e153
Compare
gkatsev
reviewed
May 15, 2017
| const initPlugin = function(player, options) { | ||
| let monitor; | ||
| const listeners = []; | ||
|
|
||
| const updateErrors = function(updates) { |
There was a problem hiding this comment.
do the default errors get passed in here during init?
There was a problem hiding this comment.
No, but they should. Good catch.
There was a problem hiding this comment.
We probably want to add a test to make sure that happens.
misteroneill
force-pushed
the
rename-new-custom-errors
branch
from
402239f to
358d43f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Changed the codes of recently-added errors; so, they will work with 1.x implementations.