Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update generate-rollup-config to drop older browser support #211

Merged
merged 3 commits into from
Dec 16, 2021

Conversation

alex-barstow
Copy link
Contributor

Description

This updates the default browserslist used by babel. It drops support for some older browsers including IE 11. This also removes the browserslist in package.json so we use the default list from @videojs/babel-config (linked above), as well as jsdoc which was unused and pointing at a defunct repo.

The plan is to merge this into a new main branch and do a major version release.

@gkatsev gkatsev changed the base branch from main to master December 15, 2021 21:20
package.json Outdated Show resolved Hide resolved
Copy link
Member

@gkatsev gkatsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving with the video.js dep change

@alex-barstow
Copy link
Contributor Author

Smoke tested in various browsers in Browserstack, looks good.

Co-authored-by: Gary Katsevman <[email protected]>
@alex-barstow alex-barstow merged commit 49fc883 into main Dec 16, 2021
@alex-barstow alex-barstow deleted the remove-older-browser-support branch December 16, 2021 18:09
alex-barstow added a commit that referenced this pull request Dec 17, 2021
)

BREAKING CHANGE: This removes support for some older browsers like IE 11

Co-authored-by: Gary Katsevman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants