Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add priorities to Builders #539

Closed
jaredcwhite opened this issue Apr 21, 2022 · 2 comments · Fixed by #567
Closed

feat: add priorities to Builders #539

jaredcwhite opened this issue Apr 21, 2022 · 2 comments · Fixed by #567
Labels
enhancement New feature or request high priority This should get addressed as soon as possible.
Milestone
1.1

Comments

@jaredcwhite
Copy link
Member

Currently builder plugins' build methods are run in the order the plugins are registered. Generally this is (order of gem requires) + ("Zeitwerk" order of local files…likely alphabetical).

We should pull in the generator-style priority system…probably by altering the Builder class hierarchy so it ultimately inherits from Bridgetown::Plugin.
@jaredcwhite jaredcwhite added this to the 1.1 milestone Apr 21, 2022
@jaredcwhite jaredcwhite added the enhancement New feature or request label Apr 21, 2022
@jaredcwhite
Copy link
Member Author

Resolved in 8b0a13f

@jaredcwhite
Copy link
Member Author

Still an issue! :( See: bridgetownrb/bridgetown-prismic#3 (comment)

@jaredcwhite jaredcwhite reopened this Jun 2, 2022
@jaredcwhite jaredcwhite added the high priority This should get addressed as soon as possible. label Jun 2, 2022
@jaredcwhite jaredcwhite mentioned this issue Jun 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request high priority This should get addressed as soon as possible.
Projects
None yet
Milestone
1.1
Development

Successfully merging a pull request may close this issue.

Ensure gem-based Builders are part of priority sorting bridgetownrb/bridgetown
1 participant
@jaredcwhite