Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disconnected from remote media player api when no other media player api is available causes unexpected behavior #67

Closed
1 task
AngelJedi opened this issue Apr 10, 2018 · 0 comments
Labels
Milestone

Comments

@AngelJedi
Copy link

  • I have verified there are no duplicate active or recent bugs, questions, or requests
Include the following:
  • PlaylistCore version: 2.0.0
  • Device OS version: 8.1..0
  • Devide Manufacturer: Google
  • Device Name: Pixel 2 XL
Reproduction Steps
  1. Disconnect from a remote media player api while no other player api is available
Expected Result

The service should shut down as there is no way to play media.

Actual Result

Media playback stops, but the service is still running and the media notification is still visible, though none of the controls do anything.

Other Information

This appears to be happening because the updateCurrentMediaPlayer() method in the DefaultPlaylistHandler sets the currentMediaPlayer = null and then calls play(), which just returns false because the player is null.

It appears, though this was not my scenario, that the same thing would happen if I did have other players registered that can't handle playback of the item too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants