Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support powerpc64-ibm-aix target #1513

Closed
wants to merge 2 commits into from
Closed

Conversation

ecnelises
Copy link
Contributor

Add support for both 64-bit PowerPC and AIX OS. The Perl scripts are from upstream OpenSSL. Keep this in draft status until it's been official Rust target.

Add support for both 64-bit PowerPC and AIX OS. The Perl scripts
are from upstream OpenSSL.
@briansmith
Copy link
Owner

I think we should de-conflate two issues: Big-endian PowerPC support and AIX support.

Regarding supporting any Big-endian target architectures at all, first I want us to resolve #1555 so that we have a general fallback implementation that works for all big-endian target architectures. Once #1555 is resolved then all PowerPC targets should "just work" as long as the operating system is allowlisted (see next item).

Regarding support for the AIX operating system, this should just be a matter of submitting a PR that updates the allowlist in rand.rs to include "aix" after verifying that the getrandom crate does use the best operating system RNG API API on AIX.

After those two things are done, then we can (re)consider whether we want to use the PowerPC optimized assembly implementations from BoringSSL.

@briansmith
Copy link
Owner

Thanks for the PR. I'm going to close this since ultimately it will need to be broken up into multiple PRs to separately address each of the aspects mentioned in the preceding comment.

@briansmith briansmith closed this Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants