Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test of MySQL server garbage collection randomly fails #937

Closed
ltangvald opened this issue Feb 1, 2018 · 4 comments
Closed

Test of MySQL server garbage collection randomly fails #937

ltangvald opened this issue Feb 1, 2018 · 4 comments
Milestone

Comments

@ltangvald
Copy link

The test at

it 'should free server resources' do
(statement close should free server resources) is testing internal server behavior that isn't fully deterministic from the outside, as the server won't always immediately free up the resources, causing the test to fail randomly in Ubuntu (MySQL 5.7)

@ltangvald
Copy link
Author

The suggested Ubuntu patch will disable the test with xit, but it should probably either be dropped or rewritten somehow.

@sodabrew
Copy link
Collaborator

sodabrew commented Feb 1, 2018

Interesting, this must have been a change in MySQL 5.7 that makes the statement unloading garbage collection less immediate.

I don't see a suggested patch?

@ltangvald
Copy link
Author

Whops, sorry :)
The patch is below, but it just works around the issue by disabling the test.

patch.txt

And yes, this is because of a change in 5.7. I seem to remember this exact same issue showing up in another package back when Ubuntu was first updated to 5.7, but can't recall which package it was.

@sodabrew sodabrew added this to the 0.5.1 milestone Mar 21, 2018
@sodabrew sodabrew modified the milestones: 0.5.1, 0.5.2 Apr 11, 2018
@sodabrew
Copy link
Collaborator

I don't want to just skip this test, since it's important to check that the Statement#close method works... I am looking into whether I can use the Performance Schema for MySQL 5.7 to measure this value without depending on MySQL's garbage collector.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants