Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Failure: Session tracking test failing against mysql 8 #1220

Closed
casperisfine opened this issue Nov 26, 2021 · 4 comments · Fixed by #1222
Closed

CI Failure: Session tracking test failing against mysql 8 #1220

casperisfine opened this issue Nov 26, 2021 · 4 comments · Fixed by #1222

Comments

@casperisfine
Copy link
Contributor

Ref: #1092

This test currently fail on CI when ran against mysql 8.0:

  1) Mysql2::Client session_track returns multiple session track type values when available
     Failure/Error: expect(res).to eq(["________"])

       expected: ["________"]
            got: nil

       (compared using ==)
     # ./spec/mysql2/client_spec.rb:1084:in `block (3 levels) in <top (required)>'

I dug a bit and mysql_session_track_get_first(wrapper->client, NUM2INT(type), &data, &length) returns 1, but I have no idea why.

@insom any idea what might be wrong?

@junaruga
Copy link
Contributor

You can see #1165 too.

@junaruga
Copy link
Contributor

Ah I see some progresses for the issue: #1222 (comment) . Thanks, forks!

@junaruga
Copy link
Contributor

Wow, thank you Shopify team!
366bd0d

@junaruga
Copy link
Contributor

@tenderlove Can you remove the allow-failure: true for the passed CI cases you confirmed in https://github.com/brianmario/mysql2/blob/master/.github/workflows/build.yml ? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants