From 33713f96ea2b5bd6d516ffd45113af86d47d1b38 Mon Sep 17 00:00:00 2001 From: Jun Aruga Date: Fri, 16 Apr 2021 16:22:33 +0200 Subject: [PATCH] GitHub Actions: Remove allow-failure on Fedora MariaDB cases. The tests pass now. Still keep allow-failure on macOS MariaDB case due to test failures that rarely happens. --- .github/workflows/build.yml | 5 ++--- .github/workflows/container.yml | 8 ++------ 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 7edefac63..05895f7b7 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -40,9 +40,8 @@ jobs: # db: A DB's brew package name in macOS case. # Set a name "db: 'name@X.Y'" when using an old version. # MariaDB lastet version - # Allow failure due to the following test failures. - # https://github.com/brianmario/mysql2/issues/965 - # https://github.com/brianmario/mysql2/issues/1152 + # Allow failure due to the following test failures that rarely happens. + # https://github.com/brianmario/mysql2/issues/1194 - {os: macos-latest, ruby: 2.4, db: mariadb, allow-failure: true} # MySQL latest version # Allow failure due to the issue #1165. diff --git a/.github/workflows/container.yml b/.github/workflows/container.yml index 39a13bbce..9ddfe42b9 100644 --- a/.github/workflows/container.yml +++ b/.github/workflows/container.yml @@ -14,13 +14,9 @@ jobs: # CentOS 7 system Ruby is the fixed version 2.0.0. - {distro: centos, image: 'centos:7', name_extra: 'ruby 2.0.0'} # Fedora latest stable version - # Allow failure due to the following test failures. - # https://github.com/brianmario/mysql2/issues/965 - - {distro: fedora, image: 'fedora:latest', allow-failure: true} + - {distro: fedora, image: 'fedora:latest'} # Fedora development version - # Allow failure due to the following test failures. - # https://github.com/brianmario/mysql2/issues/1152 - - {distro: fedora, image: 'fedora:rawhide', allow-failure: true} + - {distro: fedora, image: 'fedora:rawhide'} # On the fail-fast: true, it cancels all in-progress jobs # if any matrix job fails unlike Travis fast_finish. fail-fast: false