From?

[steveklabnik]

So, I am torn. There are a bunch of structs with a .from() method. Which is fine. But they return a Result. Rust has a trait, From, which is for lossless conversions, ie, they return T, not Result<T, _>.

So maybe these should be from_something instead? Not 100% clear.

[brianloveswords]

I think you're right, put probably not urgent enough to do a concerted cleanup. I'll start fixing those when I come across them during other work!

[jennschiffer]

...I am torn

[tkellen]

<3