Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vis.draw example from docs errors. #20

Open
KronosTheLate opened this issue Feb 13, 2023 · 1 comment
Open

Vis.draw example from docs errors. #20

KronosTheLate opened this issue Feb 13, 2023 · 1 comment

Comments

@KronosTheLate
Copy link

Original report in this discourse comment.

After running

Vis.draw(SphericalLens(Examples.Examples_N_BK7, 0.0, 10.0, 10.0, 5.0, 5.0))

successfully, I try the next line in the first example:

ulia> Vis.save("assets/test_install.png") # hide
ERROR: MethodError: no method matching size(::Makie.Figure)
Closest candidates are:
  size(::Union{LinearAlgebra.QR, LinearAlgebra.QRCompactWY, LinearAlgebra.QRPivoted}) at ~/.julia/juliaup/julia-1.8.3+0.x64.linux.gnu/share/julia/stdlib/v1.8/LinearAlgebra/src/qr.jl:581
  size(::Union{LinearAlgebra.QR, LinearAlgebra.QRCompactWY, LinearAlgebra.QRPivoted}, ::Integer) at ~/.julia/juliaup/julia-1.8.3+0.x64.linux.gnu/share/julia/stdlib/v1.8/LinearAlgebra/src/qr.jl:580
  size(::Union{LinearAlgebra.Cholesky, LinearAlgebra.CholeskyPivoted}) at ~/.julia/juliaup/julia-1.8.3+0.x64.linux.gnu/share/julia/stdlib/v1.8/LinearAlgebra/src/cholesky.jl:514
  ...
Stacktrace:
 [1] save(path::String)
   @ OpticSim.Vis ~/.julia/packages/OpticSim/5FrKf/src/Vis/Visualization.jl:269
 [2] top-level scope
   @ REPL[1]:1
Versions:
(@v1.8) pkg> st
Status `~/.julia/environments/v1.8/Project.toml`
⌃ [1520ce14] AbstractTrees v0.4.3
  [4eb35182] AutoSysimages v0.2.6
  [6e4b80f9] BenchmarkTools v1.3.2
  [54eefc05] Cascadia v1.0.2
⌃ [992eb4ea] CondaPkg v0.2.14
⌃ [717857b8] DSP v0.7.7
⌃ [a93c6f00] DataFrames v1.4.3
⌃ [82cc6244] DataInterpolations v3.10.1
  [0c46a032] DifferentialEquations v7.6.0
⌃ [31c24e10] Distributions v0.25.79
  [08be435b] EasyFFTs v0.2.0 `~/.julia/dev/EasyFFTs`
  [7a1cc6ca] FFTW v1.5.0
  [5789e2e9] FileIO v1.16.0
⌅ [e9467ef8] GLMakie v0.7.3
  [708ec375] Gumbo v0.8.2
⌅ [cd3eb016] HTTP v0.9.17
  [aef96434] HypothesisTestsExperimentalRedo v0.1.0 `https://github.com/KronosTheLate/HypothesisTestsExperimentalRedo#main`
⌃ [6218d12a] ImageMagick v1.2.1
⌃ [de52edbc] Integrals v3.3.0
⌃ [d2bf35a9] IntervalRootFinding v0.5.10
⌃ [23fbe1c1] Latexify v0.15.17
⌃ [7ed4a6bd] LinearSolve v1.29.0
  [2fda8390] LsqFit v0.13.0
  [23992714] MAT v0.10.3
  [10e44e05] MATLAB v0.8.3
  [eff96d63] Measurements v2.8.0
⌃ [8913a72c] NonlinearSolve v1.1.0
⌃ [5fb14364] OhMyREPL v0.5.12
  [24114763] OpticSim v0.6.0 `https://github.com/brianguenter/OpticSim.jl#main`
⌃ [9b87118b] PackageCompiler v2.1.0
  [65888b18] ParameterizedFunctions v5.15.0
⌃ [18e31ff7] Peaks v0.4.1
⌃ [14b8a8f1] PkgTemplates v0.7.29
⌅ [c3e4b0f8] Pluto v0.19.9
⌃ [438e738f] PyCall v1.94.1
⌃ [6099a3de] PythonCall v0.9.9
⌃ [295af30f] Revise v3.4.0
  [f2b01f46] Roots v2.0.8
  [82ae8749] StatsAPI v1.5.0
  [2913bbd2] StatsBase v0.33.21
  [78aadeae] SymbolicNumericIntegration v0.8.6
⌅ [0c5d862f] Symbolics v4.13.0
  [c544e3c2] Tau v1.0.0
  [6aa5eb33] TaylorSeries v0.12.2
⌃ [22787eb5] Term v1.0.5
⌃ [731e570b] TiffImages v0.6.2
  [75d8cae4] Tools v0.1.0 `https://github.com/KronosTheLate/Tools.jl#main`
⌃ [b8865327] UnicodePlots v3.3.0
⌃ [1986cc42] Unitful v1.12.1
⌅ [276b4fcb] WGLMakie v0.7.3
  [fdbf4ff8] XLSX v0.8.4
Info Packages marked with ⌃ and ⌅ have new versions available, but those with ⌅ are restricted by compatibility constraints from upgrading. To see why use `status --outdated`
@ederag
Copy link
Contributor

ederag commented Sep 6, 2024

This is now fixed by #39 (specifically dfac160).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants