Fixed Bricks read only issue #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I got an issue Bricks is read-only because bricks is `const` at line 176 declared so it must be `let`
|
Please have a look
|
|
Interesting I thought I had merged something similar. Will merge, thanks! |
brh55
added a commit
that referenced
this pull request
Jun 4, 2019
* [In Progress] Adds Priority Option and Fixes Data Duplications (#86) * Attempt to add in fixes suggested per other OSS modules * Add semi colon * First run for balance columns * Rename function to findMinIndex * Simplify array creation syntax * Refactor balance * Refactor priority and fix data update changes * Update example to reference project dir * Update masonry * Minor stylistic changes, comment test * Add updated snapshot * Add lazy loading functionality (#87) * Attempt to add in fixes suggested per other OSS modules * Add semi colon * First run for balance columns * Rename function to findMinIndex * Simplify array creation syntax * Refactor balance * Refactor priority and fix data update changes * Update example to reference project dir * Update masonry * Minor stylistic changes, comment test * Add updated snapshot * Add append data * Fix delay call reach * Update snapshot for lazy load * Set Alpha * Add passable props to custom images (#96) * Set alpha * Revert * passed data to customImageComponent (#94) * Update package.json * Fixed Bricks read only issue (#98) I got an issue Bricks is read-only because bricks is `const` at line 176 declared so it must be `let` * Update package.json * Update package.json (#109)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got an issue Bricks is read-only because bricks is
constat line 176 declared so it must belet