Can ConnectionProxy's Connection delegate be public?

[nonameplum]

Hi,

I started to use play-hikaricp with pgjdbc-ng and I'm using in my code database notifications using method addNotificationListener from PGConnection class.

In BoneCP I have access to PGConnection from pool using code like this:

ConnectionHandle con = (ConnectionHandle) DB.getConnection();
listeningConnection = (PGConnection) con.getInternalConnection();
listeningConnection.addNotificationListener(notificationListener);
listeningConnection.createStatement().execute("LISTEN watchers");

But Hikari does not allow me to get PGConnection from delegate member - ConnectionHandle class.

Example:

ConnectionProxy connection = (ConnectionProxy) DB.getConnection();
/// proposal getter getDelegate() - delegate member containing PGConnection is not available (protected)
listeningConnection = (PGConnection) connection.getDelegate(); 
listeningConnection.addNotificationListener(notificationListener);
listeningConnection.createStatement().execute("LISTEN watchers");

[brettwooldridge]

The proper way to do this is using the JDBC unwrap() API. And you don't need unnecessary casts to ConnectionProxy either.

Connection connection = DB.getConnection();
listeningConnection = connection.unwrap(PGConnection.class); 
listeningConnection.addNotificationListener(notificationListener);
listeningConnection.createStatement().execute("LISTEN watchers");